Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate another usage of utiltrace to component base tracing #113698

Merged
merged 1 commit into from Nov 8, 2022
Merged

Migrate another usage of utiltrace to component base tracing #113698

merged 1 commit into from Nov 8, 2022

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Nov 7, 2022 •
edited

What type of PR is this?

/sig instrumentation
/kind feature

What this PR does / why we need it:

Follow-up to #113172. I had missed one usage of utiltracing. This change keeps existing log-based "tracing" in-place without changes. It also results in OpenTelemetry spans being created for the tracing.Start calls if APIServerTracing is enabled.

Which issue(s) this PR fixes:

#113170

Does this PR introduce a user-facing change?

NONE

/assign @logicalhan

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 7, 2022
logicalhan
logicalhan approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022
@dashpole
Copy link
Contributor Author

dashpole commented Nov 7, 2022

/assign @sttts

@dashpole
Copy link
Contributor Author

dashpole commented Nov 7, 2022

Hit #113677. Link: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/113698/pull-kubernetes-integration/1589729762723500032

/retest

@dashpole dashpole mentioned this pull request Nov 8, 2022
Closed
@dims
Copy link
Member

dims commented Nov 8, 2022

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 8, 2022
@dims
Copy link
Member

dims commented Nov 8, 2022

very localized change. one file. already has approval from @logicalhan. I am comfortable getting this in.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dims, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit e361272 into kubernetes:master Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@logicalhan logicalhan

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dashpole @dims @k8s-ci-robot @logicalhan @sttts